[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [osinfo-db-tools PATCH v2 08/16] Add support to meson build system



On Thu, Jul 11, 2019 at 9:39 PM Cole Robinson <crobinso redhat com> wrote:
>
> On 7/10/19 11:25 AM, Fabiano Fidêncio wrote:
> > On Tue, Jul 9, 2019 at 12:47 PM Fabiano Fidêncio <fidencio redhat com> wrote:
> >
> > [snip]
> >
> >> +cp $BUILD_ROOT/{mingw-,}osinfo-db-tools.spec $MESON_DIST_ROOT/
> >
> > I've noticed that the current state of osinfo-db-tools tarball is to
> > just include osinfo-db-tools.spec and not mingw-osinfo-db-tools.spec.
> > Shall we keep it as it is? Or shall we also include mingw-osinfo-db-tools.spec?
> >
>
> FWIW Libvirt seems to follow the same pattern of only shipping
> libvirt.spec but not mingw-*.spec, though it does ship the .in version.
>
> Blind guess but maybe it has to do with keeping 'rpmbuild -ta
> FOO.tar.gz' working, which looks for a spec file inside the archive.

That seems to be the case, indeed.
I'll keep this pattern of just shiping osinfo-db-tools.spec and adapt
prepare release to use the shipped .spec file instead of using the one
generated during build time.

>
> - Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]