[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [osinfo-db-tools PATCH v3 0/9] Drop GVFS dependency in favour of libsoup (+ some cleanups)



On 7/11/19 3:34 PM, Fabiano FidĂȘncio wrote:
> Let's rely on libsoup in order to to http://, https://, and ftp://
> requests.
> 
> By doing this, GVFS (more specifically, gvfs-http) won't be dragged as
> a dependency, which caused errors for running osinfo-db-import as root
> (as GVFS relies on being run in the user's session).
> 
> https://gitlab.com/libosinfo/libosinfo/issues/30
> 
> The cleanups are basically in order to use g_clear_*() functions.
> 

With the caveats that my glib is weak, I've never coded against libsoup,
and I don't have any real work flow around osinfo-db-tools usage, I
didn't notice anything wrong with this series, so:

Reviewed-by: Cole Robinson <crobinso redhat com>

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]