[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libosinfo] [libosinfo PATCH v2 2/3] tree: goto cleanup on any error, on on_content_read()



Instead of just free'ing the CreateFromLocationAsyncData, let's just go
to cleanup, which will call create_from_location_async_data_free() and
return after that.

By doing so we avoid errors as:
g_task_return_error: assertion 'task->ever_returned' failed.

Signed-off-by: Fabiano Fidêncio <fidencio redhat com>
---
 osinfo/osinfo_tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/osinfo/osinfo_tree.c b/osinfo/osinfo_tree.c
index 03b6f3b..b65d399 100644
--- a/osinfo/osinfo_tree.c
+++ b/osinfo/osinfo_tree.c
@@ -676,7 +676,7 @@ static void on_content_read(GObject *source,
                                         &error)) {
         g_prefix_error(&error, _("Failed to load .treeinfo|treeinfo content: "));
         g_task_return_error(data->res, error);
-        create_from_location_async_data_free(data);
+        goto cleanup;
     }
 
     if (!(ret = load_keyinfo(data->location,
-- 
2.21.0


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]