[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [libosinfo PATCH v2 2/3] tree: goto cleanup on any error, on on_content_read()



On Wed, Jul 17, 2019 at 02:24:49PM +0200, Fabiano Fidêncio wrote:
> Instead of just free'ing the CreateFromLocationAsyncData, let's just go
> to cleanup, which will call create_from_location_async_data_free() and
> return after that.
> 
> By doing so we avoid errors as:
> g_task_return_error: assertion 'task->ever_returned' failed.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio redhat com>
> ---
>  osinfo/osinfo_tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]