[Libosinfo] [osinfo-db PATCH 00/16] RE-POST: install-scripts improvements

Cole Robinson crobinso at redhat.com
Tue Jun 18 20:22:06 UTC 2019

On 6/18/19 3:06 PM, Fabiano Fidêncio wrote:
> This patch series, together with some small bug fixes/clean-ups, tries
> to improve target, script, and avatar disks in a way that apps do not
> actually have to set them up.
> The changes do not break the current state as, if set, those disks are
> going to be used.
> With those changes, a lot of logic can be removed from the apps dealing
> with unattended installations (mainly from GNOME Boxes).
> Fabiano Fidêncio (16):
>   install-script,fedora,desktop: Drop unused bits
>   install-script,fedora: Improve script-disk template
>   install-script,fedora,desktop: Add avatar-disk template
>   install-script,silverblue: Add script-disk template
>   install-script,silverblue: Add target-disk template
>   install-script,ubuntu: Improve target-disk template
>   install-script,opensuse: Remove extra empty space
>   install-script,opensuse: Add target-disk template
>   install-script,opensuse,desktop: Add avatar-disk template
>   install-script,rhel: Only use virtio for 5.6+
>   install-script,rhel: Improve script-disk template
>   install-script,rhel,desktop: Add avatar-disk template
>   install-script,centos: Only use virtio for 5.6+
>   install-script,centos: Improve script-disk template
>   install-script,centos,desktop: Add avatar-disk template
>   install-script,rhel,centos: Merge centos & rhel scripts

Reviewed-by: Cole Robinson <crobinso at redhat.com>

I tested a centos 7 and rhel7.6 unattended install with virt-install,
seemed to work fine. Nothing jumped out at me in the patches though I
didn't fully wrap my head around all the details

- Cole

More information about the Libosinfo mailing list