[Libosinfo] [osinfo-db-tools PATCH 2/8] Add support to meson build system

[Fabiano Fidêncio]

On Thu, Jun 20, 2019 at 7:05 PM Daniel P. Berrangé <berrange at redhat.com> wrote:
>
> On Thu, Jun 20, 2019 at 06:42:29PM +0200, Pavel Hrdina wrote:
> > Few more notes that I've noticed:
> >
> >     - There is a regression, with meson we no longer have generated RPM
> >       spec files in tarball.
>
> Yep, that's desirable so users can do  "rpmbuild -ta TARBALL", though
> note only the native spec is desired - not the generated mingw spec.
>
> >     - With autotools there were some configure options:
> >         --enable-vala [default check]
> >         --enable-coverage [default no]
> >         --with-usb-ids-path [default (internal)]
> >         --with-pci-ids-path [default (internal)]
> >         --enable-werror [default git ? yes : no ]
>
> Yep, we should keep at least the last 3 args. The coverage stuff coukd
> simply be auto-detected with no arg.  I'm on the fence wrt whether we
> need a vala arg or not

No, we shouldn't.
```
fidencio at laerte /tmp/osinfo-db-tools $ ./configure --enable-vala
--enable-coverage --with-usb-ids-path --with-pci-ids-path
--enable-werror
configure: WARNING: unrecognized options: --enable-vala,
--enable-coverage, --with-usb-ids-path, --with-pci-ids-path
...
configure: WARNING: unrecognized options: --enable-vala,
--enable-coverage, --with-usb-ids-path, --with-pci-ids-path
```

About the --enable-werror, it's just a matter of passing -werror to meson.

>
> >
> >     - I'm not sure what are the best practices, but basically all of the
> >       projects using meson that I've check have the generic things like
> >       dependencies, compiler flags and so on in the root meson.build
> >       file.  All the other meson.build files handles only the
> >       compilation or code generation, ... for the specific directory.
>
> I don't think there's a strict rule that everyone follows, but yeah I'd
> probably keep general stuff at the top level, so the subdirs just focus
> on the logic needed to actally express what is being built

Hmmm. :-/
I'll re-structure that when submitting v2.

>
> > Otherwise looks good to me, but I've just started with meson myself so
> > we should get some other reviews (yes, probably Daniel :)).
>
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|