[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libosinfo] [PATCH osinfo-db 08/10] tests: test_isoinfo: don't log in match()



With the full test suite we hammer this function over 100K times.
This logging call in fact causes a lot of slow down. Dropping it
cuts time for me from ~120s to ~80s

Signed-off-by: Cole Robinson <crobinso redhat com>
---
 tests/test_isoinfo.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/test_isoinfo.py b/tests/test_isoinfo.py
index 9477942..8440bb2 100644
--- a/tests/test_isoinfo.py
+++ b/tests/test_isoinfo.py
@@ -69,8 +69,6 @@ class _ISODataMedia():
         if volumesize == 0:
             volumesize = self.volumesize
 
-        logging.warning("media.volumeid: %s | self.volumeid: %s",
-                media.volumeid, self.volumeid)
         if bool(re.match(media.volumeid, self.volumeid)) and \
            bool(re.match(media.publisherid, self.publisherid)) and \
            bool(re.match(media.applicationid, self.applicationid)) and \
-- 
2.21.0


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]