[Libosinfo] [osinfo-db PATCH] Revert "test_isoinfo: Allow running a quickier version of the test"

[Cole Robinson]

On 3/20/19 4:43 AM, Fabiano Fidêncio wrote:
> This reverts commit a5c2293c99450df46e0fec8cb7447427317dd97d.
> 
> There's no need to keep the check for the expensive tests after the
> performance improvement merged in the last 2 patches.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
>   tests/test_isoinfo.py | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/tests/test_isoinfo.py b/tests/test_isoinfo.py
> index 6de7c1d..beebcd2 100644
> --- a/tests/test_isoinfo.py
> +++ b/tests/test_isoinfo.py
> @@ -10,18 +10,12 @@ from . import util
>   
>   @pytest.mark.parametrize('_os', util.DataFiles.oses(), ids=lambda o: o.shortid)
>   def test_iso_detection(_os):
> -    expensive = os.environ.get('OSINFO_DB_ENABLE_EXPENSIVE')
> -    if expensive is not None:
> -        expensive = int(expensive)
> -    expensive = bool(expensive)
>       for isodatamedia in _get_isodatamedias(_os):
>           detected = []
>           for __os in util.DataFiles.oses():
> -            if not expensive and _os.shortid != __os.shortid:
> -                continue
>               for media in __os.medias:
>                   if isodatamedia.match(media.iso):
> -                    if expensive and _os.shortid != __os.shortid:
> +                    if _os.shortid != __os.shortid:
>                           logging.warning(
>                               'ISO \'%s\' was matched by OS \'%s\' while it '
>                               'should only be matched by OS \'%s\'',
> 

Reviewed-by: Cole Robinson <crobinso at redhat.com>

- Cole