[Libosinfo] [osinfo-db PATCH v2] tests: Add Resources tests

[Cole Robinson]

On 3/20/19 6:27 AM, Fabiano Fidêncio wrote:
> Those tests are going to ensure our database doesn't have:
> - more than one resources element for the very same arch;
> - minimum resources bigger than recommended resources;
> - recommended resources bigger than maximum resources;
> - recommended resources bigger than network install resources;
> - network resources bigger than maximum resources;
> 
> All those tests were previously part of test-os, from libosinfo
> 
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
>   tests/osinfo.py         |  58 +++++++++++++++++++++++
>   tests/test_resources.py | 101 ++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 159 insertions(+)
>   create mode 100644 tests/test_resources.py

Reviewed-by: Cole Robinson <crobinso at redhat.com>

But add that list of bits from the commit message to a block comment 
somewhere in the test file, since at a glance it's not immediately clear 
what is being tested.

For string formats I recommend using double quotes, and embedding single 
quotes. Using single quotes for both means you have to escape them all 
which just adds visual noise IMO.

- Cole