[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH osinfo-db 0/6] Add scripts/osinfo-db-add-iso.py

On Wed, 2019-03-27 at 21:08 -0400, Cole Robinson wrote:
> This series adds scripts/osinfo-db-add-iso.py, which simplifies the
> process of adding new iso data to the test suite and optionally
> filling
> in a <media> block for the <os>. Call it like:
>   ./scripts/osinfo-db-add-iso.py SHORTID [--arch ARCH] ISOPATH
> It will print a <media> block template to stdout, and generate a
> correctly named data file in tests/isodata/
> Patch #1 renames some dirs in tests/isodata/* to consistently be
> named after the <os><distro> value.
> Patch #2 adds the script
> Remaining patches tweak debian media data detection and add some more
> test cases... not strictly related to the first two patches but they
> were my test cases to get this working

Cole, I've left a comment for you in the second patch.

For the whole series:
Reviewed-by: Fabiano Fidêncio <fidencio redhat com>

And it'll be push shortly after I finished a few other reviews.

Best Regards,
Fabiano Fidêncio

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]