[Libosinfo] [osinfo-db PATCH v1 1/2] asianux: Add asianux7.3 info

Fabiano Fidêncio fidencio at redhat.com
Tue May 7 07:14:27 UTC 2019


Vicent,

On Mon, 2019-05-06 at 21:34 +0700, Vincent Dao wrote:
> diff --git a/data/os/asianux.com/asianux-7.3.xml.in
> b/data/os/asianux.com/asianux-7.3.xml.in
> new file mode 100644
> index 0000000..a2e39ea
> --- /dev/null
> +++ b/data/os/asianux.com/asianux-7.3.xml.in
> @@ -0,0 +1,41 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<libosinfo version="0.0.1">
> +
> +  <os id="http://asianux.com/asianux/7.3">
> +    <short-id>asianux7.3</short-id>
> +    <name>Asianux Server 7 SP3</name>
> +    <version>7.3</version>
> +    <vendor>Asianux Project</vendor>
> +    <family>linux</family>
> +    <distro>asianux</distro>
> +    <codename>Lotus</codename>
> +    <upgrades id="http://asianux.com/asianux/7.2"/>
> +
> +    <release-date>2019-02-26</release-date>
> +
> +    <media arch="x86_64">
> +      <iso>
> +        <system-id>LINUX</system-id>
> +        <volume-id>Asianux Server 7 SP3 x86_64</volume-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <resources arch="all">
> +      <minimum>
> +        <n-cpus>1</n-cpus>
> +        <cpu>1000000000</cpu>
> +        <ram>1073741824</ram>
> +        <storage>10737418240</storage>
> +      </minimum>
> +
> +      <recommended>
> +        <cpu>1000000000</cpu>
> +        <ram>1073741824</ram>
> +        <storage>10737418240</storage>
> +      </recommended>
> +    </resources>
> +
> +  </os>
> +</libosinfo>
> diff --git a/data/os/asianux.com/asianux-unknown.xml.in
> b/data/os/asianux.com/asianux-unknown.xml.in
> index 95d9508..dd82873 100644
> --- a/data/os/asianux.com/asianux-unknown.xml.in
> +++ b/data/os/asianux.com/asianux-unknown.xml.in
> @@ -13,7 +13,7 @@
>      <media arch="x86_64">
>        <iso>
>          <system-id>LINUX</system-id>
> -        <volume-id>Asianux Server (7 (?!SP[12])|(4
> ?!SP[67])).+</volume-id>
> +        <volume-id>Asianux Server(?!( 7 SP[123])|( 4
> SP[67])).+</volume-id>

This change will break our test suit as asianux-7.0 would be matched as
unknown.

With the following patch, it just work as expected:
```
fidencio at laerte ~/src/upstream/osinfo-db $ git diff
diff --git a/data/os/asianux.com/asianux-unknown.xml.in
b/data/os/asianux.com/asianux-unknown.xml.in
index dd82873..e58524f 100644
--- a/data/os/asianux.com/asianux-unknown.xml.in
+++ b/data/os/asianux.com/asianux-unknown.xml.in
@@ -13,7 +13,7 @@
     <media arch="x86_64">
       <iso>
         <system-id>LINUX</system-id>
-        <volume-id>Asianux Server(?!( 7 SP[123])|( 4
SP[67])).+</volume-id>
+        <volume-id>Asianux Server (7 (?!SP[123])|(4
?!SP[67])).+</volume-id>
       </iso>
       <kernel>isolinux/vmlinuz</kernel>
       <initrd>isolinux/initrd.img</initrd>
```

There's no need to submit a v2, I just would like to have your Ack on
the proposed change.

>        </iso>
>        <kernel>isolinux/vmlinuz</kernel>
>        <initrd>isolinux/initrd.img</initrd>

Best Regards,
-- 
Fabiano Fidêncio




More information about the Libosinfo mailing list