[Libvir] BUG: virDomainLookupByID fails after XenStore path discovery

[Jim Fehlig]

Daniel Veillard wrote:

>On Mon, Apr 03, 2006 at 12:01:17PM -0400, Bryan D. Payne wrote:
>  
>
>>I just updated to the latest CVS version of libvir.  It looks like  
>>there's a bug in virDomainLookupByID.  The behavior that I'm seeing  
>>is that the path variable is set and so the code never enters the  
>>block to find the value for name.  Therefore, at the end of the  
>>function, the condition (ret->name == NULL) is true and it jumps into  
>>the error code and returns NULL.
>>
>>If I comment out the code that sets the path variable, things seem to  
>>work normally.  Although, I presume that the idea was to extract the  
>>name from the path information...
>>    
>>
>
>  Right, that's a bug I introduced in the refactoring. Even if trivial
>sending a small patch (cvs diff -u) is always a good idea :-)
>  
>

AFAIK, name is not contained in the domain's home path.  Here is a patch 
I have been using for virDomainLookupByID().

Regards,
Jim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt.c.patch
Type: text/x-patch
Size: 1748 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20060404/e554f58b/attachment-0001.bin>