[Libvir] Add port number to <graphics> tag

[Daniel Veillard]

On Mon, Aug 07, 2006 at 04:20:04PM +0100, Daniel P. Berrange wrote:
> We recently added the '<graphics>' tag to the XML description for HVM
> machines. Any apps using this info though would have to hardcode the
> assumption that Xen's QEMU listens on Domain-ID + 5900. Hardcoding the
> port numbers in the first place is already a really questionable decision,
> so we should avoid that propagating out to application code.
> 
> Thus, the attached patch changes:
> 
>   <graphics type="vnc"/>
> 
> So that it now looks  like
> 
>   <graphics type="vnc" port="5905"/>
> 
> The hardcoded 'Domain-ID + 5900' craziness is now at least isolated in 
> libvirt, so provided apps take the port number from the XML they will be
> immune from changes in port numbering scheme.

  Okay, I nearly did that patch a couple of weeks ago, and then started
wondering if the port could not be extracted from some informations provided
by xend, but failed to finc anything in the xm --long output or on the
xenstore data, and didn't made the change. I really think xend should
provide the information, but agreed that's a first step toward sanity at
the application level, feel free to commit (unless someone knows how to
extract the port from xend !)

Daniel

-- 
Daniel Veillard      | Red Hat http://redhat.com/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/