[Libvir] Request for changing #include directives to conform to Linux standard

Daniel Veillard veillard at redhat.com
Mon Jun 26 14:15:45 UTC 2006

On Fri, Jun 23, 2006 at 08:46:06AM -0400, Daniel Veillard wrote:
> On Fri, Jun 23, 2006 at 12:48:26PM +0200, Philippe Berthault wrote:
> > The 'virterror.h' file has an #include directive to "libvirt.h" which 
> > isn't correct
> > because libvirt include files are installed on a sub-directory named 
> > 'libvirt'.
>   That said, I'm actually not against making the change. The problem this
> raises is a problem of source tree. If you just modify the header, then
> when compiling libvirt and including virterror.h you would load the installed
> include libvirt.h and not the one from the source tree which is a very good
> way to break the build or introduce very pernicious errors. What is required
> to make that change is to reflect the include/libvirt structure in the
> tree, moving headers in the structure, that doable but requires some not
> so nice tweaks to try to preserve CVS history without breaking existing CVS
> checkouts. I will try to do that, 

  I have just commited it to CVS. now the includes in the source tree
are under include/libvirt/ new directory. A number of files were also 
changed to add the new subdir to the include paths.


Daniel Veillard      | Red Hat http://redhat.com/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

More information about the libvir-list mailing list