[Libvir] Patch to attach/detach virtual devices on a running domain

[Daniel P. Berrange]

On Tue, Nov 14, 2006 at 03:34:05PM +0100, michel.ponceau at bull.net wrote:
> This patch adds to Libvirt-0.1.8 the two functions described in my 
> preceding mail. It has been tested in our Bull environment.

This looks good to me - only one small bug I see - in the virParseXMLDevice
function there is a memory leak. If you take 'goto errror' path through
the function, then the xmlDocPtr object will never be free'd. Thanks for
taking the time to implement all this !

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|