[Libvir] [PATCH] Fix substitution of QEMUD_PID_FILE

Richard W.M. Jones rjones at redhat.com
Tue Apr 3 11:47:36 UTC 2007

Mark McLoughlin wrote:
> On Tue, 2007-04-03 at 11:40 +0100, Richard W.M. Jones wrote:
>> Use AC_SUBST instead of AC_DEFINE because we want autoconf to
>> substitute 
>> the value into the Makefile, not into config.h.  Then add 
> 	Sounds sane ...
> 	Bear in mind, though, that ${prefix}/var is the default for
> $localstatedir ... but all Fedora packages would be built with
> --localstatedir=/var, just like --sysconfdir=/etc
> 	I don't think you see the problem if you pass a value for
> --localstatedir
>> +       -DQEMUD_PID_FILE="\"@QEMUD_PID_FILE@\""

OK, that works as well.

Are we good to commit this patch and the preceeding one (adding help to 
libvirt qemu daemon)?


Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421

Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.
Registered in England and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Charlie Peters (USA) and David
Owens (Ireland)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070403/92d1e45c/attachment-0001.bin>

More information about the libvir-list mailing list