[Libvir] Re: [PATCH] add scheduler type.

Richard W.M. Jones rjones at redhat.com
Wed Apr 4 09:36:48 UTC 2007

Atsushi SAKAI wrote:
> Hi,
> This patch intends Scheduler related API and its 1/3 of Dan Suggested.
> It adds scheduler type API for libvirt.
> Other functions like scheduler parameter show and handle
> are plan to make.
> This patch includes "virsh dominfo" can see the scheduler type
> It can be seen if you type virsh dominfo 0 on Xen(sedf or credit)
> Other scheduler does not show the scheduler information.

Returning a simple string naming the scheduler seems OK to me.

However it would be nice (for the remote case) if the string can be 
freed up by the caller.  That is, it should be allocated using strdup / 
malloc in libvirt, and the caller should be asked to explicitly free it.
In the remote case static strings are a pain.


Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421

Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.
Registered in England and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Charlie Peters (USA) and David
Owens (Ireland)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070404/ea1a4368/attachment-0001.bin>

More information about the libvir-list mailing list