[Libvir] [PATCH] Fix the value of XEN_V2_OP_GETDOMAININFOLIST

[Daniel Veillard]

On Thu, Apr 26, 2007 at 09:58:53PM +0900, Saori Fukuta wrote:
> Hi,
> 
> The value of "Max memory" shown by using "virsh dominfo" is different from xm
> command.
> 
> # virsh dominfo HVM_RH5_sda6 | grep mem
> Max memory:     300000 kB
> Used memory:    264064 kB
> 
> # xm li -l HVM_RH5_sda6 | grep mem
>     (maxmem 450)
>     (memory 292)
>     (shadow_memory 5)
> 
> So, I changed the definition as follows,
>     (before)
>     #define XEN_V2_OP_GETDOMAININFOLIST     6
>     (changed)
>     #define XEN_V2_OP_GETDOMAININFOLIST     5
> and I could get the value that I want.
> 
> # ./virsh dominfo HVM_RH5_sda6 | grep mem
> Max memory:     460800 kB
> Used memory:    299008 kB
> 
> # xm li -l HVM_RH5_sda6 | grep mem
>     (maxmem 450)
>     (memory 292)
>     (shadow_memory 5)
> 
> I think that is not mistake because the XEN_V2_OP_GETDOMAININFOLIST is a 
> system operation, so the definition is not exactly wrong.
>     /usr/include/xen/sysctl.h:#define XEN_SYSCTL_getdomaininfolist 6
> 
> Do you know any reason for this?

  No. I really can't apply such a patch as-is, the operation #5 is
/* Interface for controlling Xen software performance counters. */
#define XEN_SYSCTL_perfc_op          5

this really isn't what we are looking at. 

  What version of xen and libvirt are you using and on which architecture.
that makes no sense to me, if we were off by one, on this it would have 
broken a long time ago. What version of the xen kernel are you using too ?

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/