[Libvir] [PATCH] Fix the value of XEN_V2_OP_GETDOMAININFOLIST

[Daniel P. Berrange]

On Thu, Apr 26, 2007 at 09:58:53PM +0900, Saori Fukuta wrote:
> Hi,
> 
> The value of "Max memory" shown by using "virsh dominfo" is different from xm
> command.
> 
> # virsh dominfo HVM_RH5_sda6 | grep mem
> Max memory:     300000 kB
> Used memory:    264064 kB
> 
> # xm li -l HVM_RH5_sda6 | grep mem
>     (maxmem 450)
>     (memory 292)
>     (shadow_memory 5)
> 
> So, I changed the definition as follows,
>     (before)
>     #define XEN_V2_OP_GETDOMAININFOLIST     6
>     (changed)
>     #define XEN_V2_OP_GETDOMAININFOLIST     5
> and I could get the value that I want.
> 

This doesn't make any sense to me.

There are two hypercalls in the Xen headers, XEN_SYSCTL_getdomaininfolist
and XEN_DOMCTL_getdomaininfo, which use the same struct. The former gets
info on multiple domains, the latter on a single domain. In the libvirt 
code we always use the sysctl even when getting info for a single domain.
So XEN_V2_OP_GETDOMAININFOLIST should match XEN_SYSCTL_getdomaininfolist,
which AFAICT we already have correct.  

Does this problem occurr for you on all architectures ? Also what version
number of xen & libvirt have you got installed ?

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|