[Libvir] [PATCH] Remove VIR_DRV_OPEN_QUIET

Richard W.M. Jones rjones at redhat.com
Mon Apr 30 17:34:46 UTC 2007


Daniel P. Berrange wrote:
> On Mon, Apr 30, 2007 at 12:41:52PM +0100, Richard W.M. Jones wrote:
>> VIR_DRV_OPEN_QUIET causes important diagnostic error messages to be 
>> thrown away.  This patch removes this.
> 
> We used to use this flag to make the Xen drivers keep quite when connecting
> to test, or qemu backends. The refactoring for the xen_unified driver looks
> like it has made this unneccessary. I tested
> 
>   virsh list
>   virsh --connect test:///default list
>   virsh --connect qemu:///system list
>   virsh --connect qemu:///session list
> 
> As both root, and nonroot and all 8 combos worked without any undesired
> error messages being shown. So this looks OK to commit.

Committed to CVS.

Rich.

-- 
Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421

Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.
Registered in England and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Charlie Peters (USA) and David
Owens (Ireland)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070430/cf8c971c/attachment-0001.bin>


More information about the libvir-list mailing list