[Libvir] [PATCH] Show Xen vif<domid>.<n> device name in domain XML

[Richard W.M. Jones]

Daniel Veillard wrote:
> On Mon, Aug 20, 2007 at 10:46:45PM +0100, Daniel P. Berrange wrote:
>> On Mon, Aug 20, 2007 at 05:26:35PM +0100, Richard W.M. Jones wrote:
>>> This patch changes the Xen domain XML so that it shows the target device 
>>> (ie. vif<domid>.<n>), which you can then use to collect interface stats.
>>>
>>> For example:
>>>
>>> # virsh dumpxml fc6_1
>>>   ...
>>>     <interface type='bridge'>
>>>       <source bridge='xenbr0'/>
>>>       <target dev='vif2.0'/>
>>>       <mac address='00:16:3e:1a:2f:8c'/>
>>>       <script path='vif-bridge'/>
>>>     </interface>
>>>
>>> Note that this patch only adds to the XML, it doesn't change any XML 
>>> that was being returned before.
>> Looks fine to me. We'll also need to fix the QEMU driver too IIRC, to give
>> back the name of the auto-created TAP device
> 
>   +1, I assume this doesn't change any of the regression test data, right ?

Ahem yes.  Tests fixed and the change committed.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070821/a08d3350/attachment-0001.bin>