[Libvir] [PATCH] Fix return value of virsh vncdisplay

Masayuki Sunou fj1826dm at aa.jp.fujitsu.com
Wed Aug 29 00:26:35 UTC 2007


Hi

Virsh vncdisplay always returns 1,
because return value is not set in the case of normal end.
------------------------------------
# virsh vncdisplay test
:0

# echo $?
1
------------------------------------

This patch fixes it.

Signed-off-by: Masayuki Sunou <fj1826dm at aa.jp.fujitsu.com>

Thanks,
Masayuki Sunou.

----------------------------------------------------------------------
Index: libvirt/src/virsh.c
===================================================================
RCS file: /data/cvs/libvirt/src/virsh.c,v
retrieving revision 1.100
diff -u -p -r1.100 virsh.c
--- libvirt/src/virsh.c	21 Aug 2007 11:53:52 -0000	1.100
+++ libvirt/src/virsh.c	28 Aug 2007 06:33:03 -0000
@@ -2919,6 +2919,7 @@ cmdVNCDisplay(vshControl * ctl, vshCmd *
     }
     xmlXPathFreeObject(obj);
     obj = NULL;
+    ret = TRUE;
 
  cleanup:
     if (obj)
----------------------------------------------------------------------




More information about the libvir-list mailing list