[Libvir] using gnulib: starting with the physmem and getaddrinfo modules

[Richard W.M. Jones]

Jim Meyering wrote:
> diff --git a/m4/Makefile.am b/m4/Makefile.am
> deleted file mode 100644
> index 188b2fe..0000000
> --- a/m4/Makefile.am
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -
> -EXTRA_DIST = compiler-flags.m4
> -

Does this mean that compiler-flags.m4 is no longer going into the 
tarball?  Shouldn't it?

> -libvirtd_LDADD = ../src/libvirt.la
> +libvirtd_LDADD = ../src/libvirt.la ../lib/libgnu.la

Shouldn't we be using LIBOBJS (automake feature) here?  I kind of 
thought this was how gnulib worked, and it was what I used for the 
previous getaddrinfo implementation.

> +#include "getaddrinfo.h"

This include doesn't need to be conditional?

I checked the rest of the patch, and it's fine.  Unfortunately since I 
reinstalled Windows (for like, the 3rd time) yesterday I can't test it 
there yet, but will do later.

I'd very much like to see something along these lines go in.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071205/b64c611f/attachment-0001.bin>