[Libvir] [PATCH] fix compilation if readline lib is not available

Richard W.M. Jones rjones at redhat.com
Thu Dec 6 10:58:57 UTC 2007


Daniel Veillard wrote:
>   The current CVS code doesn't compile on RHEL5/F6 because readline lib
> there require ncurses, and we removed that check earlier. Sor we find
> the readline headers but the lib is not found. Unfortunately virsh.c
> tests the availablility of the header to use readline, and link time failures
> follow. The patch below:
>    - exports a READLINE_CFLAGS from configure if used
>    - use the READLINE_CFLAGS when compiling virsh.c
>    - change virsh.c to rely on this instead of the header test
>    - adds a message about readline usage at the end of configure
> 
>     configure: Miscellaneous
>     configure: 
>     configure:   Debug: no
>     configure:   Readline: yes
>     configure: 
> 
> Another patch available soon should fix the readline library detection itself,

+1

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071206/e0b83f28/attachment-0001.bin>


More information about the libvir-list mailing list