[Libvir] more missing #include's of "config.h"

Richard W.M. Jones rjones at redhat.com
Thu Dec 6 18:19:48 UTC 2007


Daniel Veillard wrote:
> On Thu, Dec 06, 2007 at 06:32:24PM +0100, Jim Meyering wrote:
>> This is the last of the non-generated files requiring #include "config.h":
>>
>> 	Include "config.h" in remaining non-generated files.
>>         * docs/examples/info1.c: Likewise.
>> 	* docs/examples/suspend.c: Likewise.
> 
> For those 2 files I don't agree with adding it, they are example files
> showing how to use the API and config.h is an internal header, those 
> user level examples should really not include it.
> But for the other case this looks fine to me,

Same comment.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071206/6e3453af/attachment-0001.bin>


More information about the libvir-list mailing list