[Libvir] [PATCH] Fix detach-disk command for tap device

Fri Dec 14 14:32:53 UTC 2007

On Fri, Dec 14, 2007 at 10:21:54AM +0000, Richard W.M. Jones wrote:
> Saori Fukuta wrote:
> >The detach-disk command does not work for tap device, since
> >xenStoreDomainGetDiskID is always searching for vbd device from
> >XenStore. c.f. This is a the related patch:
> >http://git.et.redhat.com/?p=libvirt.git;a=commit;h=d27506d3a36e12b977f6a896bae5082134db8fb5
> >
> >So, I changed the searching path to both vbd and tap.
> 
> +1 from me.  If no one else objects I'll commit it next week.

ACK, no problem. I really wish I had paid more attention when tap went
upstream so XenD didn't have this insanity :-(

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 