[Libvir] [PATCH] to run on IA64

Atsushi SAKAI sakaia at jp.fujitsu.com
Mon Feb 19 08:50:51 UTC 2007


Hi, Dan

Thank you for your comments.
1) This patch is for rpmbuild failure on IA64.
      see the attached log (it is stopped in conf.c compilation)

2) About above fixes code.(endian issue)
   Sorry for short discripting this issue.
   My point is you are casting (unsigned int*) for unsigned char.
   In little endian, this works fine (conf.c).
   But big endian case, this inputs "00" for character value.

Thanks
Atsushi SAKAI


"Daniel P. Berrange" <berrange at redhat.com> wrote:

> On Fri, Feb 16, 2007 at 07:24:19PM +0900, Atsushi SAKAI wrote:
> > Hi,
> > 
> > This patch intends to run libvirt 0.2.0 on IA64.
> > 
> > Signed-off-by: Atsushi SAKAI <sakaia at jp.fujitsu.com>
> 
> This patch looks fine to me - I assume its just about silencing warnings
> from ever stricter GCC compiles.
> 
> > Just one question, is there any plan to support big/little 
> > endian for libvirt? (related to network)
> 
> The current protocol used in QEMU backend is 'native' endianness, since it
> is only accessible over UNIX sockets & thus doesn't need to worry about
> endianness mismatch. When we add off-host remote management we'll need to
> ensure that all the data types are fixed sizes (eg int32_t instead of int)
> and that we pick a fixed byteorder. Rich Jones' work is using SunRPC as
> the network transport which, IIRC, mandates fixed sizes, and will always
> use network byte order to ensure compatabilty across archs.
> 
> Dan.
> -- 
> |=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
> |=-           Perl modules: http://search.cpan.org/~danberr/              -=|
> |=-               Projects: http://freshmeat.net/~danielpb/               -=|
> |=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: libvirtraw.txt
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070219/7e73b153/attachment-0001.txt>


More information about the libvir-list mailing list