[Libvir] [PATCH]Report the error from xend for Domain-0

Richard W.M. Jones rjones at redhat.com
Wed Feb 28 08:39:27 UTC 2007


Daniel P. Berrange wrote:
> On Tue, Feb 27, 2007 at 07:34:01PM +0900, Kazuki?$B!!Mizushima wrote:
>> When I test virsh subcommands, dump save, for Domain-0,
>> It says following normal messages, but the processing is not done.
>>
>> -    } else if ((ret = 202) && (strstr(content, "failed") != NULL)) {
>> +    } else if ((ret == 202) && (strstr(content, "failed") != NULL)) {
> 
> Yikes - that's a good catch - compiler wasn't even complaining because it
> was surrounded in brackets. I'll apply this fix shortly.

Yes, that's a good reason NOT to bracket tests.

Rich.

-- 
Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421
  "[Negative numbers] darken the very whole doctrines of the equations
  and make dark of the things which are in their nature excessively
  obvious and simple" (Francis Maseres FRS, mathematician, 1759)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070228/703fc3ee/attachment-0001.bin>


More information about the libvir-list mailing list