[Libvir] Option string in getopt_long wrong?

Richard W.M. Jones rjones at redhat.com
Tue Jan 30 16:25:55 UTC 2007


Daniel Veillard wrote:
> On Fri, Jan 26, 2007 at 11:38:58AM +0000, Richard W.M. Jones wrote:
>>     while ((arg = getopt_long(end, argv, "d:hqtv", opt, &idx)) != -1) {
>>                                           ------
>>         switch (arg) {
>>             case 'd':
>>                 ctl->debug = atoi(optarg);
>>                 break;
>>             case 'h':
>>                 help = 1;
>>                 break;
>>             case 'q':
>>                 ctl->quiet = TRUE;
>>                 break;
>>             case 't':
>>                 ctl->timing = TRUE;
>>                 break;
>>             case 'c':
>>                 ctl->name = vshStrdup(ctl, optarg);
>>                 break;
>>         // etc
>>
>> Shurley shome mishtake?
> 
>   Right, thanks, fixed in CVS ;-)

Actually the patch you put in is slightly wrong - it needs a colon (':')
after the c, ie: "d:hqtcv" -> "d:hqtc:v"

Rich.

-- 
Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421
  "[Negative numbers] darken the very whole doctrines of the equations
  and make dark of the things which are in their nature excessively
  obvious and simple" (Francis Maseres FRS, mathematician, 1759)




More information about the libvir-list mailing list