[Libvir] PATCH: Make QEMU driver honour 'listen' flag for VNC

[Daniel P. Berrange]

On Tue, Jul 24, 2007 at 03:18:23AM -0400, Daniel Veillard wrote:
> On Mon, Jul 23, 2007 at 08:51:36PM +0100, Daniel P. Berrange wrote:
> > On Mon, Jul 23, 2007 at 07:06:25PM +0100, Daniel P. Berrange wrote:
> > > In QEMU 0.9.0 or later it is possible to tell QEMU to only listen on a
> > > particular IP address. THis patch adapts the code so that it honours the
> > > 'listen' attribute on the <graphics> tag if using QEMU >= 0.9.0. It also
> > > re-enables the tests for this capability that I temporarily disabled.
> > 
> > There was a further complication of this. It turns out our handling of
> > headless VMs was broken -ie, VMs without any <graphics> tag all. We
> > specify -nographic on the command line. Unfortunately when you do this,
> > QEMU splatters any settings for monitor, serial or parallel device you
> > gave on the command line before the -nographic flag. Unfortunately again
> > we order  -monitor pty before -nographic, so we fail to get a monitor
> > console setup correctly.  This updated patch extends the previous so
> > that we have -nographic before all other args it might affect.
> 
>   Hum, a program whose behaviour depends on the order of the flags,
> is taht really intended upstream ?

Yeah, the upstream behaviour makes sense in the context in which they've
done it & has been like that in QEMU for ages - I just didn't realize the
implications of it wrt to way libvirt spawns QEMU.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|