[Libvir] Re: PATCH 1/2: Qemu feature reporting

[Richard W.M. Jones]

David Lutterkort wrote:
> This patch lets the qemu/kvm drivers report features for i686 and
> x86_64. The output is table-driven, like the rest of the capability
> generation. That should make it easy to report additional features for
> other arches (which I know zip about)

This patch is fine, except I'd recommend using the STREQ/STRNEQ macros 
(defined in src/internal.h) instead of:

+        if (strcmp(flags[i].name, "pae") == 0) {

But it's not a big problem.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070725/bdeda615/attachment-0001.bin>