[Libvir] PATCH: Overhaul the test driver

Richard W.M. Jones rjones at redhat.com
Tue Jul 31 11:53:38 UTC 2007


Daniel P. Berrange wrote:
> The test driver has suffered from quite alot of bitrot. Its got all sorts
> of checks in the driver entry points already done by libvirt.c, its got
> private data, redundantly pointing to private data, it doesn't implement
> any of the networking APIs, is missing alot of the newer domain APIs. So
> I've given it a thorough overhaul to remove alot of redundant code, clean
> up more, and add entry points for all the APIs except for VCPU pinning ones.
> 
> The addition of the networking APIs means we no longer get errors thrown
> when trying to run tests without the libvirt daemon running, and means apps
> can actually do tests for their networking capabilities.
> 
>  docs/testnetdef.xml   |   12 
>  docs/testnetpriv.xml  |   11 
>  docs/testnode.xml     |    2 
>  src/driver.h          |    1 
>  src/libvirt.c         |   17 
>  src/qemu_driver.c     |    1 
>  src/remote_internal.c |    1 
>  src/test.c            | 1892 +++++++++++++++++++++++++++++++-------------------
>  tests/virshtest.c     |  465 +++---------
>  9 files changed, 1382 insertions(+), 1020 deletions(-)

It's a big patch which mixes mechanical changes & functional changes. 
There is nothing obviously wrong.  I see that it's in CVS now, so I'll 
give it a go there.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070731/4a98b9d7/attachment-0001.bin>


More information about the libvir-list mailing list