[Libvir] [PATCH] Readd buffer errors & some cleanups
Richard W.M. Jones
rjones at redhat.com
Wed Jul 4 09:11:19 UTC 2007
Daniel Veillard wrote:
> On Tue, Jul 03, 2007 at 11:47:20AM +0100, Richard W.M. Jones wrote:
>> This readds some error checking of the returns from virBuffer*
>> functions, removes need for is_blank (a _GNU_SOURCE extension), and a
>> couple of other very minor cleanups.
>
> Looks fine to me, I just wonder about:
>
> - while (p && *p && isblank((unsigned char) *p))
> + while (p && *p && (*p == ' ' || *p == '\t'))
>
> I don't think we have support for multiline commands so this should
> be fine, but '\n' and '\r' could be tested too.
>
> in any case +1
isblank is defined as "a space or a tab" [from the man page], hence the
substitution above.
I'll apply the patch.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070704/2d5c172b/attachment-0001.bin>
More information about the libvir-list
mailing list