[Libvir] [PATCH] virDomainMigrate version 4 (for discussion only!)

[Daniel Veillard]

On Thu, Jul 19, 2007 at 05:52:35PM +0100, Richard W.M. Jones wrote:
> Attached is an updated patch which adds a "virsh migrate" subcommand.

  patch looks fine to me. That will allow testing :-)

> I also rebuilt the API & Python binding using the generator.
> 
> Two known problems with the auto-generated Python binding at the moment:
> 
> (1) It's attached to the connection object (conn.migrate (...)) instead 
> of the domain object (dom.migrate (...)).  It looks like the generator 
> is confused about a function which takes both a domain ptr and a connect 
> ptr.

  Hum, maybe I could look what I did for libxml2, usually the function then
can attach to both classes. I wonder why it's different here.

> (2) I need to get the generator to export the VIR_MIGRATE_LIVE flag.  At 
> the moment you need to pass 0|1 for the flag parameter.

  Strange, macros should show up, at least they do at the XML level (e.g.
       <exports symbol='VIR_DOMAIN_SCHED_FIELD_LENGTH' type='macro'/> )
maybe that's something I did in the libxml2 generator but didn't backport in
libvirt.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/