[Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen

[Daniel Veillard]

On Fri, Jul 27, 2007 at 04:24:46PM -0700, David Lutterkort wrote:
> Updated patch, incorporating feedback.
> 
> Besides formatting, changes how apic is reported - and that's not
> pretty. As danpb found out, in cset 12423:ebed72718263 in xen-unstable,
> setting the apic was removed from tools/libxc/xc_hvm_build.c. 
> 
> In a surprising turn of events, cset 12569:9d6bc06919e0 claims to
> reintroduce apic toggling (with a default of 1/on) by writing it into an
> hvm_info_table in tools/python/xen/lowlevel/xc/xc.c - I haven't figured
> out why the apic can't be toggled in rawhide, though.
> 
> For now, the code uses the hypervisor version to determine what apic
> capability to report - most likely not the right thing to do, better
> suggestions much appreciated.

  In the absence of a better idea, I commited this patch. I just changed a
bit the XML output indenting,

   thanks a lot !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/