[Libvir] [PATCH] header file changes for Solaris

Mark Johnson johnson.nh at gmail.com
Fri Jun 15 13:32:13 UTC 2007

As johnlev said, I can fix the limits_iso.h with limits.h

> <string.h> is in ISO C, but <strings.h> is not.  So as Daniel Veillard
> said you can include the former without checks, but the latter should be
> defended with an #ifdef HAVE_STRINGS_H.
> On BSD, <strings.h> has the legacy functions like bcopy and index.  Are
> we using those?  Shouldn't we instead replace any instances with memcpy
> / memmove / strchr / strrchr?

It's needed because of index().

> There are apparently some platforms where you can't include both ...
> urrgh: http://gcc.gnu.org/ml/gcc-patches/1998-08/msg00317.html

That can break on BSD and solaris since they have both string.h and
strings.h which don't overlap.

More information about the libvir-list mailing list