[Libvir] [PATCH] Fix the check of <cpumap> in virsh vcpupin

Richard W.M. Jones rjones at redhat.com
Mon Jun 18 11:02:01 UTC 2007

Masayuki Sunou wrote:
> Hi
> Because virsh vcpupin does not check a form of <cpumap>,
> when non-numerical letters are set, it does not become an error.
> This patch fixes it so that it become an error when non-numerical
> letters are set.

You mean cpulist instead of cpumap?  Your patch doesn't deal with 
strings like "1,,,,3".

<rant> It's 2007 - we should not be writing any more software in C. </rant>

There seem to be another problem with the documentation of virsh vcpupin 
too.  It's documented as 'virsh vcpupin <domain>' yet takes two other 
parameters, so should really be 'virsh vcpupin <domain> <vcpu> <cpulist>'.

The attached patch (not applied) should fix all of the above.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-vcpupin-20070618.patch
Type: text/x-patch
Size: 2368 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070618/9791570c/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070618/9791570c/attachment-0003.bin>

More information about the libvir-list mailing list