[Libvir] PATCH 5/9: Adapt to virError API

Richard W.M. Jones rjones at redhat.com
Mon Jun 18 12:53:18 UTC 2007

Daniel P. Berrange wrote:
> And with the actual patch...
> On Mon, Jun 18, 2007 at 03:18:40AM +0100, Daniel P. Berrange wrote:
>> This patch switches the driver.c, conf.c and dispatch.c files over to use
>> the virError object and associated API instead of a custom version.

I don't know if I like this ...

> +extern void __virRaiseError(virConnectPtr conn,
> +                            virDomainPtr dom,
> +                            virNetworkPtr net,
> +                            int domain,
> +                            int code,
> +                            virErrorLevel level,
> +                            const char *str1,
> +                            const char *str2,
> +                            const char *str3,
> +                            int int1, int int2, const char *msg, ...)
> +  ATTRIBUTE_FORMAT(printf, 12, 13);

although I can see why you did it.  Would it be better to move the 
prototype of __virRaiseError out of src/internal.h and into 
include/libvirt/virterror.h?  We declare and export other __internal 
symbols already.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070618/78d34566/attachment-0001.bin>

More information about the libvir-list mailing list