[Libvir] [PATCH] Fix string handling in virDomain{Get, Set}SchedulerParameters
Atsushi SAKAI
sakaia at jp.fujitsu.com
Fri Jun 22 09:33:52 UTC 2007
Hi, Rich
Thank you for your review and fix.
+1
Thanks
Atsushi SAKAI
"Richard W.M. Jones" <rjones at redhat.com> wrote:
> This small patch fixes some bugs in the handling of the field string in
> virDomainGetSchedulerParameters and makes a similar pre-emptive fix to
> virDomainSetSchedulerParameters.
>
> Also, please don't use !strcmp(a,b), because it confuses me. Better is
> to write strcmp(a,b) == 0 to mean "strings match" and strcmp(a,b) != 0
> to mean "strings don't match".
>
> Rich.
>
> --
> Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
> Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
> England and Wales under Company Registration No. 03798903
More information about the libvir-list
mailing list