[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Add virDomainGetConnect and virNetworkGetConnect

Daniel Veillard wrote:
On Mon, Jun 25, 2007 at 02:58:48PM +0100, Richard W.M. Jones wrote:
As described in this thread:


* These functions don't change the reference count for virConnectPtr. It's be a pain in the neck for callers otherwise. * I haven't changed the Python bindings, because I'm not confident enough that I can do that correctly and keep it backwards compatible for all callers (and anyway what would happen if newer Python bindings were used together with an older libvirt?). However I did add a comment to the generator noting that this could be changed in future.
* I tested this with the OCaml bindings with no apparent ill-effects.

  Looks fine, but change virNetworkGetConnect comment to use "network"
and not "connection" ;-)

Duh ... Committed, with your fix.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]