[Libvir] [PATCH] check the maximum of virtual CPU

[Masayuki Sunou]

Hi, Rich

> The patch looks pretty sensible to me.  Needs the same check added to 
> virt-manager too?
> 
Virt-manager seems to check maximums of the number of CPU. 

However, virt-manager checks the number of CPU by fixed value (32). 
Therefore, I think that the check of architecture is needed in the future. 


Thanks,
Masayuki Sunou.


In message <45E68CA1.3030406 at redhat.com>
   "Re: [Libvir] [PATCH] check the maximum of virtual CPU"
   ""Richard W.M. Jones" <rjones at redhat.com>" wrote:

> Masayuki Sunou wrote:
> > Hi
> > 
> > The maximum of virtual CPU is not guarded in virsh setvcpus now.
> > Then, when 32767 was set to virtual CPU of virsh setvcpus, the problem
> > that Xend became abnormal was detected.
> > 
> > example:
> > ----------------------------------------------------------------------
> >   # virsh setvcpus 0 32767
> >   libvir: Xen Daemon error : POST operation failed: (xend.err "(9, 'Bad file descriptor')")
> >   libvir: Xen error : failed Xen syscall  ioctl  3166208
> >   libvir: error : library call virDomainSetVcpus failed, possibly not supported
> >   
> >   # xm list -l
> >   Error: (9, 'Bad file descriptor')
> >   Usage: xm list [options] [Domain, ...]
> >   
> >   List information about all/some domains.
> >     -l, --long                     Output all VM details in SXP
> >     --label                        Include security labels
> >     --state=<state>                Select only VMs with the specified state
> > ----------------------------------------------------------------------
> > 
> > 
> > Therefore, I propose the correction that adjusts the maximum of virtual
> > CPU to the same value as Xen. 
> > 
> > 
> > This patch is over 200lines.
> > If you request, I am ready to repost it with split this patch.
> 
> The patch looks pretty sensible to me.  Needs the same check added to 
> virt-manager too?
> 
> Rich.
> 
> -- 
> Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
> 64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421
>   "[Negative numbers] darken the very whole doctrines of the equations
>   and make dark of the things which are in their nature excessively
>   obvious and simple" (Francis Maseres FRS, mathematician, 1759)
> 
> 
> 
> --
> Libvir-list mailing list
> Libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 
> 
>