[Libvir] [PATCH] export virConf* symbols (second version)
Richard W.M. Jones
rjones at redhat.com
Thu Mar 1 13:58:35 UTC 2007
Mark McLoughlin wrote:
> Hi Rich,
> On Wed, 2007-02-28 at 17:33 +0000, Richard W.M. Jones wrote:
>> +#define virConfNew() (_virConfNew())
> I wouldn't bother doing this, it just adds confusion - e.g. it helps to
> know that the symbol is private from the calling site too, so just use
> _virConfNew() everywhere ...
> Also suggest surrounding everything with:
> #ifdef LIBVIRT_PRIVATE_API_DO_NOT_USE
> in src/conf.h (even though it's not installed) so that people have no
> excuse if they use this ...
Thanks Mark. I'll put up a third version later (probably tomorrow in
fact, I'm building & fixing computers today).
More information about the libvir-list