[Libvir] [PATCH] check the maximum of virtual CPU

Daniel Veillard veillard at redhat.com
Wed Mar 7 22:02:39 UTC 2007

On Tue, Mar 06, 2007 at 08:08:57PM +0900, Masayuki Sunou wrote:
> Hi, Dan
> > >  1. When initially creating a VM
> > >  2. When changing the config of an inactive VM
> > >  3. When changing the config of a running VM
> > > 
> Certainly, I had not considered concerning 1 and 2.
> So, I corrected the patch based on your proposal.
>  ・ virDomainGetMaxVcpus
>    Judge state (active/inactive) of the domain, and return information
>    corresponding to each state. 
>  ・ virConnectGetMaxVcpus
>    Add it as a method that returns the number of maximum CPUs defined by Xen. 
> However, I only added virConnectGetMaxVcpus because I did not understand
> the use image of it. 
> Is it added as a command of virsh?
> Or, is it used from virsh create and virsh start?
> Signed-off-by: Masayuki Sunou <fj1826dm at aa.jp.fujitsu.com>

  Looks good to me, the new function comment should be fixed to avoid the
'Thje' typo, and 'make rebuild' should be run in the doc subdir to regenerate
documentations, but it's IMHO ready to be applied.

  Thanks a lot !


Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/

More information about the libvir-list mailing list