[Libvir] [PATCH] Enable USB device setting information handling on virsh.
veillard at redhat.com
Thu Mar 29 08:20:08 UTC 2007
On Thu, Mar 15, 2007 at 05:54:19PM +0900, Masayuki Sunou wrote:
> Hi Daniel
> I contribute some corrected patches.
> 1. strtok() --> strtok_r()
> --> Add tok_buf for strtok_r()
> 2. Correct the first argument of strtok_r()
> 3. Add a version of XML
> --> So that the format of XML may change in the future
> Signed-off-by: Masayuki Sunou <fj1826dm at aa.jp.fujitsu.com>
I realized I forgot to answer to that patch. Let's not drop the issue !
The problem is that this new patch still seems to follow the old XML
of the initial patch while following Dan Berrange last post it looks
better to integrate the USB specific part in other logical blocs. I
don't think adding a version number is the right approach, it's better to
get the XML set up straight rather than put the burden on long term
maintainance and at the user level to decode the different ways to
express the same thing.
I also don't like strtok_r too much I admit but it's a separate issue :-)
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard at redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
More information about the libvir-list