Add lots of warning flags to CFLAGS [was Re: [Libvir] Remote patch, 2007-02-28]

Richard W.M. Jones rjones at redhat.com
Thu Mar 1 16:13:04 UTC 2007


Mark McLoughlin wrote:
> On Thu, 2007-03-01 at 16:06 +0000, Mark McLoughlin wrote:
>> @@ -75,7 +77,7 @@ dnl
>>  dnl make CFLAGS very pedantic at least during the devel phase for everybody
>>  dnl
>>      if test "${GCC}" = "yes" ; then
>> -       CFLAGS="-g -O -W -Wformat -Wunused -Wimplicit -Wreturn-type -Wswitch -Wcomment -Wtrigraphs -Wformat -Wchar-subscripts -Wuninitialized -Wparentheses -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Winline -Wredundant-decls -Wall"
>> +       CFLAGS="-Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls"
>>      fi
>>  
> 
> 	Uh, never mind this ... fixed patch attached.

Looks great.

Rich.




More information about the libvir-list mailing list