Add lots of warning flags to CFLAGS [was Re: [Libvir] Remote patch, 2007-02-28]

Thu Mar 1 16:16:07 UTC 2007

On Thu, Mar 01, 2007 at 04:09:26PM +0000, Mark McLoughlin wrote:
> On Thu, 2007-03-01 at 16:06 +0000, Mark McLoughlin wrote:
> > @@ -75,7 +77,7 @@ dnl
> >  dnl make CFLAGS very pedantic at least during the devel phase for everybody
> >  dnl
> >      if test "${GCC}" = "yes" ; then
> > -       CFLAGS="-g -O -W -Wformat -Wunused -Wimplicit -Wreturn-type -Wswitch -Wcomment -Wtrigraphs -Wformat -Wchar-subscripts -Wuninitialized -Wparentheses -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Winline -Wredundant-decls -Wall"
> > +       CFLAGS="-Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls"
> >      fi
> >  
> 
> 	Uh, never mind this ... fixed patch attached.

Looks good to me, lets commit it.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 