[Libvir] [PATCH] modular compilation of xen/qemu/test

Richard W.M. Jones rjones at redhat.com
Wed Mar 14 15:51:59 UTC 2007


Daniel Veillard wrote:
>   The following patch adds 3 configure options to turn on or off
> the support for Xen, QEMU/KVM and the test driver, as the output
> of configure --help shows:
> ...
>   --with-xen              add XEN support (on)
>   --with-qemu             add QEMU/KVM support (on)
>   --with-test             add test driver support (on)
> ...
> 
>  It uses compile time flags, is not really intrusive, it just pointed out
> a few strangeness, one of which was fixed (a Xen include) and the remaining
> ones are:
>    - xml.c doesn't depend on Xen except for virDomainXMLDevID calling
>      xenStoreDomainGetNetworkID()
>    - libvirt.c still calls xenDaemonDomainLookupByName_ids from
>      virDomainGetUUID() , I'm not sure if this can be avoided
> In the tests directory, sexpr2xmltest.c and xmconfigtest.c still depends on
> code in xen specific modules, trying to add them without xen being present
> was more complex than the value it may add (it also makes the patch smaller
> to cut at the module level).
> 
>   Plan to commit this before the release, unless this raises a problem,

That's really needed.  I was going to do something like this myself for 
the remote case.

Rich.

-- 
Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421
  "[Negative numbers] darken the very whole doctrines of the equations
  and make dark of the things which are in their nature excessively
  obvious and simple" (Francis Maseres FRS, mathematician, 1759)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070314/db131e26/attachment-0001.bin>


More information about the libvir-list mailing list