[Libvir] [patch 4/5] iptables: maintain rules in memory even when not writing to disk
Daniel Veillard
veillard at redhat.com
Wed Mar 21 13:15:32 UTC 2007
On Wed, Mar 21, 2007 at 12:48:01PM +0000, Mark McLoughlin wrote:
> Re-factor things a little for the next patch so that we maintain
> the rules in memory even when we're not going to write them to
> disk.
[...]
> if (!(r = (char **)realloc(rules->rules, sizeof(char *) * (rules->nrules+1))))
> return ENOMEM;
Seems the rules tab is zeroed, but when you extend it you don't
zeroe the new part of the array, but it may not give problem in
practice (or a very hard one to track down ;-)
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard at redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
More information about the libvir-list
mailing list