[Libvir] [PATCH] Three cleanup patches

Richard W.M. Jones rjones at redhat.com
Fri May 11 12:22:44 UTC 2007

Daniel P. Berrange wrote:
> On Fri, May 11, 2007 at 11:15:29AM +0100, Richard W.M. Jones wrote:
>> Daniel Veillard wrote:
>>> On Thu, May 10, 2007 at 05:24:00PM +0100, Richard W.M. Jones wrote:
>>>> * Add some extra generated files to .cvsignore
>>>> * Remove an unused header in qemud/uuid.c
>>>> * Log an error if xenHypervisorOpen fails because xenHypervisorInit has 
>>>> failed.
>>>  just wondering about the last one, would that add a message if trying
>>> as non-root ?
>> Yes it does, so that third patch is wrong.  In fact xenHypervisorInit 
>> already produces errors for all paths except the one where opening the 
>> HV connection fails.
> Just make reporting the HV initialization error message conditional on
> getuid() == 0. We always want to see the error if root, and never if
> non-root.

That's not good.  With the call to virXenError as is in the patch, it 
would hide other important errors.  If we move the error to the part 
where it can't open /proc/xen/privcmd, then people would get that error 
when they didn't have Xen installed (more of a feature than an error).

>> OK to commit the first two?
> Yes.

About to commit.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street,
Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in England and 
under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070511/c732029a/attachment-0001.bin>

More information about the libvir-list mailing list