[Libvir] PATCH: Fix uninitialized variable & bridge setup
Richard W.M. Jones
rjones at redhat.com
Fri May 11 18:53:42 UTC 2007
Daniel P. Berrange wrote:
> Two crazy bugs
ACK to both, but ...
> - I forgot an =0 initialization in a recent patch to deal with qemu startup
> @@ -246,7 +246,7 @@ static int qemudExtractVersionInfo(const
> _exit(-1); /* Just in case */
> } else { /* Parent */
> char help[8192]; /* Ought to be enough to hold QEMU help screen */
> - int got, ret = -1;
> + int got = 0, ret = -1;
> int major, minor, micro;
>
> if (close(newstdout[1]) < 0)
... I'm really surprised that gcc doesn't warn about this one. I'm
always compiling with full warnings and -Werror.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070511/bff17cbd/attachment-0001.bin>
More information about the libvir-list
mailing list